Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[tart3rsauc3]

I'm making a rock paper scissors game. Apparently my first compare function isn't working correctly. I've looked over it a bazillion times and I don't understand why it still isn't right. The exercise always says, "Your compare function doesn't return the correct string when comparing x to y".

var compare = function(choice1, choice2) {
   choice1 = userChoice;
   choice2 = computerChoice;
   if(choice1 == choice2) {
      return "The result is a tie!";
   }
   else if(choice1 == "rock") {
      if(choice2 == "scissors") {
      return "rock wins";
      } else {
         return "paper wins";
      }
   }
};

[mustyoshi]

Why are you setting choice1 and choice2 inside the function?

Also, you only check if choice1 is rock, you need to check if choice1 is paper or scissors.

Also, if you wanted to be real efficient like. A better way to do it would be to make choice1 and choice2 numbers
0 = paper
1 = rock
2 = scissors

You'll notice the next one in the list (if it wrapped around) is the one that is beaten by it's previous.

result = (choice1 - choice2)
So if results is less than 0 player 1 lost, if it's 0, then it was a tie, and if its greater than 0, player 1 won.

[cgm]

var userChoice = prompt("Do you choose rock, paper or scissors?");
var computerChoice = Math.random();
if (computerChoice <0.34){
computerChoice = "rock";
}else if(computerChoice <=0.67){
computerChoice = "paper";
}else{
computerChoice = "scissors";
}
/*if (computerChoice <0.34){
computerChoice = "rock";
}else if(computerChoice <=0.67){
computerChoice = "paper";
}else{
computerChoice = "scissors";
}*/
var compare = function (choice1 , choice2)
{
if (choice1 === choice2)
{
return "The result is a tie!";
}if(choice1 === "rock")
{
if (choice2 === "scissors")
{
return "rock wins";
} else {
return "paper wins";
}}
if (choice1 === "paper")
{
if (choice2 === "rock")
{
return "paper wins";
} else{
return "scissors wins";
}}
if (choice1 === "scissors")
{
if (choice2 === "rock")
{
return "rock wins";
}else
{
return "scissors wins";
}
}
};
compare(userChoice,computerChoice);

[tart3rsauc3]

Why are you setting choice1 and choice2 inside the function?

This. This made my function work correctly. Haha.

It was a code snippet. Adding in checks for if choice1 is paper or scissors comes later in the exercise. It'll be like what cgm posted.
Thank you.

[k9rosie]

Here, I wrote this for you:
http://jsfiddle.net/wey5S/2/

You already figured it out but I'm sharing it with you anyway so you can read the mini documentation I put on there.

Here is the code without docs:
http://jsfiddle.net/wey5S/3/

[tart3rsauc3]

Here, I wrote this for you:
http://jsfiddle.net/wey5S/2/

You already figured it out but I'm sharing it with you anyway so you can read the mini documentation I put on there.

Here is the code without docs:
http://jsfiddle.net/wey5S/3/

Thank you!
This helped me understand a lot.